Fix eslint trying to look at node_modules/
#275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously: ```sh $ npm run lint > [email protected] lint > eslint **/*.js Oops! Something went wrong! :( ESLint: 8.37.0 You are linting "node_modules/ipaddr.js", but all of the files matching the glob pattern "node_modules/ipaddr.js" are ignored. If you don't want to lint these files, remove the pattern "node_modules/ipaddr.js" from the list of arguments passed to ESLint. If you do want to lint these files, try the following solutions: * Check your .eslintignore file, or the eslintIgnore property in package.json, to ensure that the files are not configured to be ignored. * Explicitly list the files from this glob that you'd like to lint on the command-line, rather than providing a glob as an argument. ```
MadLittleMods
added
the
T-Task
MadLittleMods
added a commit
that referenced
this pull request
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix eslint trying to look at
node_modules/. I'm not sure what exactly is causing the behavior change now besides that I am running on Linux.The quote fix around the path is from https://stackoverflow.com/questions/51021751/express-js-lint-gives-mistake
node_modules/is already part of our.eslintignorehttps://github.com/matrix-org/matrix-public-archive/blob/1d3e930fbd57788ed60494a64835127ff97dbd53/.eslintignore#L1
Previously: